knacky/mimic
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(make): auto-detect docker/podman so Makefile works on either engine #4

Merged
knacky merged 1 commits from sprint/2-simulations into main 2026-05-26 10:34:01 +00:00
Conversation 0 Commits 1 Files Changed 5 +38 -16
knacky commented 2026-05-26 10:33:56 +00:00
Owner
Copy Link
  • Makefile: introduce CONTAINER_CMD ?= $(shell command -v docker || echo podman),
    replace all 12 hardcoded docker invocations with $(CONTAINER_CMD). User can
    override with make <target> CONTAINER_CMD=podman or env export.
  • e2e/tests/us1-bootstrap-admin.spec.ts: AC-1.4 regex updated to match the new
    variable form $(CONTAINER_CMD) exec … flask create-admin (was hardcoded
    docker exec). RUNTIME default also auto-detects (same logic as Makefile)
    so the test exec'es the right engine without a MIMIC_CONTAINER_CMD export.
  • e2e/tests/us6-deployment.spec.ts: same RUNTIME auto-detect so the make-dry-run
    regex assertions on lines 75 + 77 match what the Makefile actually emits on
    a podman-only host.
  • README + CHANGELOG document the new behavior.

Fixes the user-reported issue: "Le makefile ne fonctionne pas sur ma machine
qui n'a que podman."

Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com

- Makefile: introduce CONTAINER_CMD ?= $(shell command -v docker || echo podman), replace all 12 hardcoded `docker` invocations with $(CONTAINER_CMD). User can override with `make <target> CONTAINER_CMD=podman` or env export. - e2e/tests/us1-bootstrap-admin.spec.ts: AC-1.4 regex updated to match the new variable form `$(CONTAINER_CMD) exec … flask create-admin` (was hardcoded `docker exec`). RUNTIME default also auto-detects (same logic as Makefile) so the test exec'es the right engine without a MIMIC_CONTAINER_CMD export. - e2e/tests/us6-deployment.spec.ts: same RUNTIME auto-detect so the make-dry-run regex assertions on lines 75 + 77 match what the Makefile actually emits on a podman-only host. - README + CHANGELOG document the new behavior. Fixes the user-reported issue: "Le makefile ne fonctionne pas sur ma machine qui n'a que podman." Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
knacky added 1 commit 2026-05-26 10:33:56 +00:00
fix(make): auto-detect docker/podman so Makefile works on either engine b3124ba4dd 
- Makefile: introduce CONTAINER_CMD ?= $(shell command -v docker || echo podman),
  replace all 12 hardcoded `docker` invocations with $(CONTAINER_CMD). User can
  override with `make <target> CONTAINER_CMD=podman` or env export.
- e2e/tests/us1-bootstrap-admin.spec.ts: AC-1.4 regex updated to match the new
  variable form `$(CONTAINER_CMD) exec … flask create-admin` (was hardcoded
  `docker exec`). RUNTIME default also auto-detects (same logic as Makefile)
  so the test exec'es the right engine without a MIMIC_CONTAINER_CMD export.
- e2e/tests/us6-deployment.spec.ts: same RUNTIME auto-detect so the make-dry-run
  regex assertions on lines 75 + 77 match what the Makefile actually emits on
  a podman-only host.
- README + CHANGELOG document the new behavior.

Fixes the user-reported issue: "Le makefile ne fonctionne pas sur ma machine
qui n'a que podman."

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
knacky merged commit 52611337c2 into main 2026-05-26 10:34:01 +00:00
knacky deleted branch sprint/2-simulations 2026-05-26 10:34:01 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
knacky
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: knacky/mimic#4
Delete Branch "sprint/2-simulations"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?