Two issues spotted by ux-frontend consuming docs/api.md against the actual
code path:
1. `flask.abort(...)` returned the Werkzeug HTML error page for 400/403/404/
422/etc. — only the 401 paths going through `api_error()` and the
Flask-Login `unauthorized_handler` honoured the `{error, message}`
envelope the contract promised. The frontend's `ApiClientError.body`
parser was forced to fall back to a raw string, and the 422 case
could not surface Pydantic per-field errors.
Fix: register `@app.errorhandler(HTTPException)` that serialises every
`HTTPException` to the same JSON envelope. 422s gain a `details: [...]`
field holding the Pydantic `errors()` list (`loc` / `msg` / `type`),
matching the shape now documented in `docs/api.md`.
A `_HTTP_ERROR_CODES` map maps statuses to stable snake_case codes
(`bad_request`, `not_found`, `method_not_allowed`,
`validation_error`, `forbidden`, `internal_error`, ...). Unknown
statuses fall back to `http_error`.
`description` is `cast(object, ...)` because the Werkzeug stub pins it
to `str | None` while `flask.abort(..., description=<list>)` is the
officially supported way to smuggle a Pydantic errors list to the
handler.
2. `@bp.get("")` on the engagements blueprint produced `/api/v1/engagements`
(no slash). Hitting it with a trailing slash issued a 308 redirect,
and some browsers drop the session cookie across that hop.
Fix: `app.url_map.strict_slashes = False`. Both forms now match the
same handler without redirect.
5 new integration tests cover the new envelope shape (422 with details,
unknown 404, malformed-JSON 400) and the dual-slash matching. `docs/api.md`
rewritten to reflect the table of stable codes, the `details` shape, and
the no-trailing-slash convention. `CHANGELOG.md` gains a follow-up entry.
Verification: ruff check / mypy --strict / pytest tests/unit all green
(61 unit + 5 new integration).
9.4 KiB
9.4 KiB
Changelog
All notable changes to Mimic. Format inspired by Keep a Changelog (https://keepachangelog.com).
Versioning starts at 0.1.0 when sprint 0 lands.
[Unreleased]
Sprint 1 — backend follow-up fixes (feature/backend-auth-wiring)
- Global JSON error envelope — register
@app.errorhandler(HTTPException)so every aborted request now flows through the same{ "error": "<code>", "message": "<human>", "details"? }JSON shape thatdocs/api.mddocumented but onlyapi_error()honoured before. 422 responses surface the Pydantic per-field list underdetailsso the frontend can map errors back to form fields. New stable codes:bad_request,not_found,method_not_allowed,validation_error,forbidden,internal_error, etc. (see updateddocs/api.md). strict_slashes=Falseon the URL map —/api/v1/engagementsand/api/v1/engagements/match the same handler. Removes the 308 redirect that some browsers drop the session cookie through.- 5 new integration tests covering both slash variants, 422
validation_errorenvelope shape (incl.details), unknown-route 404, and 400 on a non-JSON body. docs/api.mdrewritten: full error code table, 422detailsexample, trailing-slash policy, dropped trailing slashes from all endpoint headings.
Sprint 1 — backend auth wiring (feature/backend-auth-wiring)
POST /api/v1/auth/login— local-credentials login. Body{username, password}; success returns theCurrentUsershape (user_id,username,display_name,role,permissions,groups) and sets a Flask session cookie. Failures return a uniform401 invalid_credentialsenvelope; a bcrypt round runs against a dummy hash on unknown users to flatten the timing signal.POST /api/v1/auth/logout— clears the session, returns204. Writes anauth.logoutaudit row.GET /api/v1/auth/me— rehydrates the frontend at boot; returns the current principal or401 not_authenticated.- Error envelope — every API failure now returns
{error: "<code>", message: "<human>"}.LoginManager.unauthorized_handleris wired to the same shape so@login_required401s match. - Dev-only CORS —
flask-corswraps/api/*for the origins inMIMIC_CORS_ORIGINSonly whenMIMIC_ENV=development. Prod keeps same-origin via the reverse proxy. AuthUserextended — carriesdisplay_name+user_typeso the serialiser can return them.- Audit —
auth.loginandauth.logoutrows go through the existing hash-chained writer. - Docs —
docs/api.mddescribes the contract the frontend consumes (login flow, CurrentUser shape, error envelope, MA6 tenant-scope behaviour). - Tests — 5 unit tests on the schemas + serializer; integration scaffold
test
tests/integration/test_auth_engagement_e2e.pyexercises the full login → /me → POST engagement → list → logout loop on a testcontainers Postgres.
Team decisions (2026-05-21)
- Q1 — SOC client collaboration in the live cockpit is assumed valid (no PoC sheet).
- Q2 — Mimic is deployed on RT infrastructure (not at client). SOC client connects over the internet through the existing RT reverse proxy (out of Mimic scope).
- Q3 — Project framed as "improve the existing shared sheet workflow", not "rebuild Caldera".
- T2 — C2 credentials stored in a dedicated
c2_credentialtable with version + retirement (Fernet-encryptedconfig_json). Active row per engagement =retired_at IS NULL, max version. - T3 — Jinja templating exposes two accessors:
{{outputs.text}}(stdout) and{{outputs.blob("key")}}(binary, 10 MB cap, UTF-8 with latin-1 fallback). - T4 —
soc_session.token_opaquestores a bcrypt hash; the clear token is delivered out-of-band and never re-displayable. - Auth — v1: local user/password (bcrypt + Flask session). v2: Keycloak OIDC mapping onto the same group model. RBAC is group-based from day one.
Sprint 0 in progress
Repo skeleton, data model, C2Connector ABC, Jinja2 sandbox, local auth + RBAC, flat CRUD,
UX wireframes (mock data). No real connector, no reporting until PR1/PR2/PR3 land.
Backend skeleton (feature/backend-skeleton)
backend/Python 3.12+ project:pyproject.toml(ruff, mypy strict, pytest, coverage 70 %),Makefile(Docker/Podman auto-detect), multi-stageDockerfile,compose.ymlfor Postgres dev DB,.env.example.- Full §8 data model in SQLAlchemy 2 typed mapped classes:
engagement,c2_credential,host,user,group,permission,group_permission,user_group,engagement_member,ttp,scenario,scenario_step,run,run_step,run_step_cleanup,detection,evidence,report,soc_session,audit_log. Nottp_versiontable (D-009 / H32 reaffirmed). - Alembic baseline migration
202605210001_initial_schema: every table + enum + index + idempotentaudit_loggrants for the write-only Postgres role. Seeds the three F11 groups (rt_operator,rt_lead,soc_analyst) and their permission set (D-008). C2ConnectorABC +Payload/TaskHandle/TaskResult/TaskStatusdataclasses +PayloadTypeenum +ConnectorFactorykeyed onc2_type. Mythic payload map populated; Home stays empty until PR2.- Jinja2
SandboxedEnvironment+regex_extractfilter (google-re2hard dependency per D-011 / B1 —RuntimeErrorat boot if absent, norefallback) +{{ outputs.text }}/{{ outputs.blob() }}accessors reading gzip-compressed blobs (10 MB cap after decompression, UTF-8 → latin-1). - Group-based RBAC:
Permission+GroupName+GROUP_PERMISSIONSmirror the F11 matrix;@require_permdecorator +AuthUserFlask-Login wrapper that resolves the permission set from the user's groups. - bcrypt password helpers + SOC opaque token (256-bit url-safe, bcrypt-hashed at rest, plain returned once).
- Hash-chained append-only audit writer (sprint 0 fills
prev_hash/row_hashat insert; verifier shipped in v2). - Flat CRUD blueprints: engagements / hosts / TTPs / scenarios + scenario steps. F3 invariant
enforced (host.c2_type must match scenario.c2_type at compose time). Every mutation calls
the hash-chained audit writer (MA5); created rows carry
created_by_id(MA4); listings and per-engagement routes scope toengagement_memberfor RT operators (MA6 / F11). - Content-addressed gzip blob store (
mimic.storage.blob): streaming write with amax_bytescap (raisesBlobTooLargemid-stream — MA2), atomic rename,0o750directory mode. mimic-cli(click):user create,db dump,db restore.- pytest baseline: 56 unit tests passing (templating, regex_extract, password, soc_token,
RBAC matrix, connector factory, audit hash, blob CAS, migration seed parity). Integration
scaffold ready for testcontainers Postgres (
/healthzsmoke included).
Spec deltas applied in this sprint
Authoritative decisions implemented per tasks/spec-decisions.md:
- D-008 — Seeded groups = exactly the three F11 roles, permission matrix from F11.
- D-009 — No
ttp_versiontable (H32 reaffirmed). - D-011 —
regex_extractfails loudly on no-match (raisesTemplateError). - D-012 —
output_blob_refstored inMIMIC_BLOB_ROOT(CAS gzip layout); evidence files live underMIMIC_EVIDENCE_ROOT(flat per-engagement).
Implementation arbitrations logged in this sprint:
- D-013 —
audit_loghash chain (prev_hash/row_hash) shipped v1. - D-014 — UUID columns use SQLAlchemy 2 native
Uuidmapping; notype_annotation_mapon the declarative base (Flask-SQLAlchemy incompatibility).
Code-review remediation (12d131c → feature/backend-skeleton)
- B1 — Dropped the
restdlib fallback inregex_extract.google-re2is now a hard dependency (B1 / D-011); the module raisesRuntimeErrorat import if absent. - MA1 — Removed
scripts/postgres-init/00-roles.sql(no more hardcodedCHANGE_MEpassword). Audit-writer role provisioning is the playbook's responsibility (D-010);backend/README.mddocuments the manual dev-onlyCREATE ROLEcommand. - MA2 —
store_blobnow accepts a binary stream +max_bytes, streams sha256+gzip in 64 KB chunks, and raisesBlobTooLargemid-stream (cleans up the temp file). No more whole-buffer RAM load. - MA3 — Inlined the F11 permission matrix in the initial Alembic migration; the runtime
matrix is no longer imported there. A new unit test
(
test_migration_seed_matches_current_matrix) fails if the two drift apart. - MA4 —
created_by_id = current_user.idset inengagement,ttp, andscenariocreate endpoints. - MA5 — Every mutation endpoint now writes an audit row through the hash-chained
AuditWriter(F13). - MA6 — RT operators only see engagements they are members of (
engagement_memberjoin on list, membership probe onget/put/delete/host/scenario/...). RT leads bypass. - N4 —
gunicorndeclared inpyproject.tomldependencies (the DockerfileCMDnow resolves correctly). - N6 —
tests/integration/conftest.pykeepsdb.create_all()for now; commented TODO to switch over to Alembic once the playbook owns the audit role. - M8 — Initial migration docstring no longer mentions
ttp_version.
Verification on the latest commit: ruff check, ruff format --check, mypy --strict, and
pytest tests/unit all pass; 56 unit tests green.