From fc530af78b4383c46384728bd7245f1df749fce4 Mon Sep 17 00:00:00 2001 From: Knacky Date: Wed, 27 May 2026 20:39:01 +0200 Subject: [PATCH] =?UTF-8?q?fix(frontend):=20post-code-review=20NITs=20?= =?UTF-8?q?=E2=80=94=20btn-ink=20uses=20@apply=20bg-slab,=20unify=20New=20?= =?UTF-8?q?engagement=20label?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - btn-ink: replace inline background-color #111827 with @apply bg-slab (and add slab-hover token #1f2937 for the hover state) so the token system is consistent - EngagementsListPage: header button "+ New" → "+ New engagement" to match empty-state CTA label Co-Authored-By: Claude Sonnet 4.6 --- frontend/src/pages/EngagementsListPage.tsx | 2 +- frontend/src/styles/index.css | 5 ++--- frontend/tailwind.config.ts | 1 + 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/frontend/src/pages/EngagementsListPage.tsx b/frontend/src/pages/EngagementsListPage.tsx index 0c3fdb4..1f3f05b 100644 --- a/frontend/src/pages/EngagementsListPage.tsx +++ b/frontend/src/pages/EngagementsListPage.tsx @@ -42,7 +42,7 @@ export function EngagementsListPage(): JSX.Element { {canEditEngagements ? ( - New + New engagement ) : null} diff --git a/frontend/src/styles/index.css b/frontend/src/styles/index.css index 1a4cc43..4155cb9 100644 --- a/frontend/src/styles/index.css +++ b/frontend/src/styles/index.css @@ -80,11 +80,10 @@ /* btn-ink uses fixed dark slab so it doesn't invert in dark mode */ .btn-ink { - @apply inline-flex items-center justify-center gap-xs text-white uppercase tracking-[0.7px] font-semibold text-[14px] leading-[1.4] rounded-md px-xl py-sm h-11 transition-colors; - background-color: #111827; + @apply inline-flex items-center justify-center gap-xs bg-slab text-white uppercase tracking-[0.7px] font-semibold text-[14px] leading-[1.4] rounded-md px-xl py-sm h-11 transition-colors; } .btn-ink:hover { - background-color: #1f2937; + @apply bg-slab-hover; } .btn-ink:disabled { @apply bg-steel cursor-not-allowed; diff --git a/frontend/tailwind.config.ts b/frontend/tailwind.config.ts index 2fee123..56a10b1 100644 --- a/frontend/tailwind.config.ts +++ b/frontend/tailwind.config.ts @@ -36,6 +36,7 @@ const config: Config = { graphite: 'var(--color-graphite)', // Fixed dark slab — never inverts in dark mode (utility strip, footer, dark bands) slab: '#111827', + 'slab-hover': '#1f2937', 'slab-text': '#f9fafb', 'slab-muted': '#6b7280', // Semantic / decorative — fixed (not themeable)