From ddf48dd1d1a4611b40ce7993099d5014b9fca4e3 Mon Sep 17 00:00:00 2001 From: Knacky Date: Tue, 26 May 2026 16:14:37 +0200 Subject: [PATCH] docs(changelog): post-QA fixes summary + e2e suite now fully green MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Document the 4 post-QA fixes (i18n FR→EN, password field alignment, execution_result TextArea, unified sticky action bar) - Update the e2e suite status: 68/68 passing on both docker and podman (sprint 1 us1/us6 failures resolved by b3124ba's auto-detect that also landed in those specs) Co-Authored-By: Claude Opus 4.7 (1M context) --- CHANGELOG.md | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d133b67..d94e2c2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -25,10 +25,17 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/) - `ConfirmDialog`: generic modal used by the delete flow. - TanStack Query hooks: `useEngagementSimulations`, `useSimulation`, `useCreateSimulation`, `useUpdateSimulation`, `useDeleteSimulation`, `useTransitionSimulation`, `useMitreSearch`. Mutations invalidate both the simulation detail key and the engagement-scoped list key. -**Acceptance tests** (Playwright, 68 specs) +**Acceptance tests** (Playwright, **68/68 passing**) - 6 new spec files (one per user story US-7 → US-12), 32 tests, all green. -- `us4-engagements.spec.ts` AC-4.9 assertion refreshed: the Sprint 1 placeholder text was correctly replaced by the new `SimulationList` (the test now asserts the new heading + "Nouvelle simulation" link). -- 5 pre-existing failures in `us1-bootstrap-admin.spec.ts` and `us6-deployment.spec.ts` remain — they hard-code `docker` in the test body and fail in dev environments that only have `podman`. The fixtures already support `MIMIC_CONTAINER_CMD`; the test bodies don't yet. Out of scope for Sprint 2 — to be picked up later. +- `us4-engagements.spec.ts` AC-4.9 assertion refreshed: the Sprint 1 placeholder text was correctly replaced by the new `SimulationList` (the test now asserts the new heading + "New simulation" link). +- Sprint 1 docker-hardcoded tests (`us1`, `us6`) now resolve thanks to the podman auto-detect added to those specs in the same sprint — full suite is green on both docker and podman hosts. +- E2e assertions translated to match the i18n cleanup (French → English) shipped in the post-QA fix. + +**Post-QA fixes (2026-05-26)** +- All French labels in the frontend translated to English (convention: anglais partout). Affected: `SimulationList`, `SimulationFormPage`, `ConfirmDialog` strings. +- `UsersAdminPage` "Create account" form: grid alignment fixed — the password field's `hint="≥ 8 characters"` was pushing labels out of alignment with `items-end`. Now uses `items-start` + `self-end` button wrapper so labels sit at the same baseline and the Create button stays bottom-aligned. +- `SimulationFormPage` "Execution result" field: switched from single-line `TextInput` to multiline `TextArea` (5 rows). +- `SimulationFormPage` actions reorganised: single sticky action bar at the bottom of the page replaces the previous split between RT-card footer, SOC-card footer, and workflow div. Layout: Save Red Team · Save SOC · | · Mark for review · Close · (right-aligned) Delete. ### Changed - 2026-05-26 — `make update-mitre` upgraded from no-op placeholder to a real `curl` + optional container restart (Sprint 1 marker resolved).