Backend pushed the authoritative contract in docs/api.md and tightened
the error envelope via a global HTTPException handler (dd5c508). This
commit folds the frontend onto that contract — every drift flagged by
the code-reviewer MAJOR is closed.
Types (src/types/api.ts)
- User: `id` → `user_id`; `display_name` is `string | null`; add
`permissions: string[]` and `groups: string[]`; drop `engagement_id`
and `engagement_name` (not part of CurrentUser).
- Engagement: drop `name`, `client_name` is non-null `string`; status
enum aligned to `draft | active | closed | archived`; `c2_type` is
non-null `C2Type`; drop `created_at` (not in EngagementRead v1).
- EngagementCreate body: `client_name` required, plus optional
`description`, `c2_type`, `start_date`, `end_date`. No `name`.
- Replace ApiError + ApiValidationError with a single uniform envelope:
`{ error: string, message: string, details?: PydanticErrorItem[] }`,
matching the new HTTPException handler. PydanticErrorItem is the
per-field shape on 422 (`{ loc, msg, type }`).
Fetch client (src/lib/api.ts)
- `bodyAsApiError` now recognizes the uniform envelope by shape
(error+message strings). Anything else returns null so callers fall
back to a generic message — keeps us robust if the backend ever
emits a non-JSON response.
Engagements API (src/screens/engagements/engagementsApi.ts)
- Drop the `{ items: [] }` envelope tolerance — backend serves a bare
`Engagement[]`.
- Hit `/engagements/` with trailing slash explicitly; backend now sets
`strict_slashes=False` but staying consistent with docs/api.md.
EngagementsPage
- Status tone map switched to the new enum (`draft → pending`,
`closed → soc`).
- Drop "Name" column. `client_name` is the primary identifier; the
description column replaces the now-meaningless name field.
- `c2_type` is non-null, so no nullable rendering path.
EngagementCreateDialog
- Drop `name` field. New required field is `client_name`; add a
`c2_type` select (default `mythic`); brief textarea stays optional.
- `mapValidationErrors` now reads `body.details[*].loc` (last segment
matches the form field) — direct alignment with the backend's new
shape after dd5c508.
- 401 still surfaces "Session expirée"; 403 gains a dedicated message;
other errors fall back to a capitalized backend `message` when
available, then to a generic French string.
Sidebar
- Display fallback: `user.display_name ?? user.username` (now nullable).
- Drop the `ENG · {engagement_name}` line; show `user.username` (the
email) as the secondary identity instead.
LoginPage
- Field label "Username" → "Email or username" so RT users with email
accounts find the field semantically obvious (per docs/api.md note
on the username/email mapping).
Tests (Vitest, 14 cases, all green)
- Refreshed fixtures to the new shapes (no more `name`, no
`created_at`, status `draft`, envelopes carry `error`+`message`).
- New 422 test exercises the `details[*].loc` mapping shape.
- New 401 test on the dialog covers the top-of-form alert path.
LoginPage
- RT mode now POSTs /api/v1/auth/login with controlled username/password
fields. Success seeds the session cache via queryClient.setQueryData and
navigates to /engagements. 401 surfaces as the generic
"Identifiants invalides" — no echo of the backend detail (avoids
user enumeration leaks).
- SOC mode kept visually for masthead continuity but disabled with a
"sprint 2" placeholder pointing at the deferred
POST /api/v1/auth/soc/session endpoint.
- Removed the sprint-0 mock role-picker.
EngagementsPage
- MOCK_ENGAGEMENTS dropped. useQuery against fetchEngagements (handles
both bare-array and { items: [] } envelope shapes — backend has not
pinned this yet).
- Distinct loading / empty / error states. Error row surfaces an HTTP
code and a Retry button. Empty state offers the create dialog.
- Column shape aligned with the real Engagement schema (snake_case:
name, client_name, c2_type, start_date, end_date). Dropped mock-only
columns (operators, socAnalysts) — those land when backend exposes
/engagements/:id/members and /engagements/:id/soc-sessions counts.
engagementsApi.ts
- fetchEngagements + createEngagement, both bound to /api/v1/engagements.
- ENGAGEMENTS_QUERY_KEY exported so the dialog can invalidate without
re-knowing the key.
EngagementCreateDialog (frontend-design skill — new non-trivial component)
- "Arm engagement" mission-control dialog. Backdrop is a graphite dim
with a faint scanline overlay (no soft blur) — reads as "cockpit
paused while you issue a command", not as a SaaS modal.
- Surface --surface-3 with corner-marks and an amber hairline accent
under the title; underline-style inputs that light amber on focus;
label-system uppercase microtypography throughout.
- Esc + outside-click close (suspended while the mutation is in flight).
- Rudimentary tab focus trap.
- 422 Pydantic errors map per-field via the last loc segment;
401/5xx surface as a generic top-of-form alert.
- On 201 invalidates ['engagements'] and closes.
