From 7a69f10f3ee66cb687ae77a76aea8dfd7fc184ec Mon Sep 17 00:00:00 2001 From: Knacky Date: Tue, 12 May 2026 18:58:51 +0200 Subject: [PATCH] =?UTF-8?q?docs(m4):=20post-review=20polish=20=E2=80=94=20?= =?UTF-8?q?helper=20text=20+=20test=20counts?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Spec-reviewer PASS pointed two factual nits: - MitrePage helper text still referenced the old 3-column drill-down ("Pick a tactic on the left, then a technique..."). Reworded for the flat matrix with the ▸ glyph + hover-for-id idiom. - testing-m4.md + CHANGELOG were stale at 51/12; the actual counts are 53/14 after the GET /mitre/matrix tests landed. Reconciled. No code-path change, no e2e fallout — DoD remains 53 pytest + 34 Playwright. Co-Authored-By: Claude Opus 4.7 (1M context) --- CHANGELOG.md | 2 +- frontend/src/pages/MitrePage.tsx | 2 +- tasks/testing-m4.md | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index de4897e..f9a71bd 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -34,7 +34,7 @@ All notable changes to this project will be documented here. Format: [Keep a Cha ### Validated end-to-end (M4 DoD) - `make clean && make up && make migrate && make seed-mitre` → 15 tactics / 222 techniques / 475 sub-techniques / 254 links / 0 orphans / ~1.1 s. -- `make test-api` → **51 pytest pass** (1 health + 8 schema + 15 auth + 15 RBAC + 12 MITRE) in ~5 s. +- `make test-api` → **53 pytest pass** (1 health + 8 schema + 15 auth + 15 RBAC + 14 MITRE) in ~5 s. - `make e2e` → **34 Playwright pass** (8 M0 + 4 M1 + 8 M2 + 8 M3 + 6 M4) in ~18 s. - Spec-reviewer PASS after fixes applied. diff --git a/frontend/src/pages/MitrePage.tsx b/frontend/src/pages/MitrePage.tsx index 411da1c..a674aad 100644 --- a/frontend/src/pages/MitrePage.tsx +++ b/frontend/src/pages/MitrePage.tsx @@ -118,7 +118,7 @@ export function MitrePage() { {selected.length === 0 && (

- Pick a tactic on the left, then a technique, then optionally a sub-technique. Selections accumulate. + Click any cell to toggle. Use to reveal sub-techniques inline. Hover a cell for its external_id. Selections accumulate.

)} diff --git a/tasks/testing-m4.md b/tasks/testing-m4.md index 7df8996..1de7211 100644 --- a/tasks/testing-m4.md +++ b/tasks/testing-m4.md @@ -21,7 +21,7 @@ make seed-mitre # télécharge le bundle pinné v19.0 (~50 MB, ~1 s parse) ## 2. Tests automatisés ```bash -make test-api # 51 tests pytest dont 12 nouveaux MITRE (parser + endpoints) +make test-api # 53 tests pytest dont 14 nouveaux MITRE (parser + 5 read endpoints + matrix + status) make e2e # 34 tests Playwright dont 6 M4 ```